Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: set 23.1.8 as MinSupportedVersion for sql-stats/mixed-version #123321

Merged
merged 1 commit into from
May 1, 2024
Merged

roachtest: set 23.1.8 as MinSupportedVersion for sql-stats/mixed-version #123321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/cmd/roachtest/tests/mixed_version_sql_stats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ func registerSqlStatsMixedVersion(r registry.Registry) {
func runSQLStatsMixedVersion(ctx context.Context, t test.Test, c cluster.Cluster) {
roachNodes := c.Range(1, c.Spec().NodeCount-1)
workloadNode := c.Node(c.Spec().NodeCount)
mvt := mixedversion.NewTest(ctx, t, t.L(), c, roachNodes)
mvt := mixedversion.NewTest(ctx, t, t.L(), c,
roachNodes, mixedversion.MinimumSupportedVersion("v23.1.8"))
flushInterval := 2 * time.Minute

initWorkload := roachtestutil.NewCommand("./cockroach workload init tpcc").
Expand Down Expand Up @@ -163,7 +164,7 @@ func getCombinedStatementStatsURL(
) string {
searchParams := fmt.Sprintf("?fetch_mode.stats_type=%d&start=%d&end=%d&limit=10",
statsType, requestedRange[0].Unix(), requestedRange[1].Unix())
return `http://` + adminUIAddr + `/_status/combinedstmts` + searchParams
return `https://` + adminUIAddr + `/_status/combinedstmts` + searchParams
}

// timeRange is a pair of time.Time values.
Expand Down
Loading