staging-v23.1.20: release-23.1: jobs: avoid errors related to fraction completed #123133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
FractionProgressed is used by jobs that do a substantial amount of work. Failing the entire job because it has miscalculated its fraction progressed estimate is not good. Here, we leave the error state for non-release builds but log in release builds. Epic: none Release note (bug fix): A job will now log rather than fail if it reports an out-of bound progress fraction.
blathers-crl
bot
force-pushed
the
blathers/backport-staging-v23.1.20-122963
branch
from
31b1c69 to
72a0c79
Compare
blathers-crl
bot
added
blathers-backport
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
msbutler
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #122963 on behalf of @stevendanna.
/cc @cockroachdb/release
Backport 1/2 commits from #122674.
/cc @cockroachdb/release
Release justification: Bug fix for bug that results in failed backup.