Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roleoption: fix error message for SUBJECT option #123063

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Apr 25, 2024

The string formatting logic was incorrect before.

fixes #123062
Release note: None

The string formatting logic was incorrect before.

Release note: None
@rafiss rafiss added the backport-24.1.x Flags PRs that need to be backported to 24.1. label Apr 25, 2024
@rafiss rafiss requested review from bdarnell, souravcrl and a team April 25, 2024 16:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@souravcrl souravcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rafiss
Copy link
Collaborator Author

rafiss commented Apr 25, 2024

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 25, 2024

Build failed:

@rafiss
Copy link
Collaborator Author

rafiss commented Apr 25, 2024

bors retry

@craig craig bot merged commit 7c9bab9 into cockroachdb:master Apr 25, 2024
22 checks passed
Copy link

blathers-crl bot commented Apr 25, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-24.1-123063 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/123072/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rafiss rafiss deleted the fix-subject-err-msg branch April 25, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
3 participants