release-23.2: storage: fix TestMVCCStatsRandomized's handling of timestamps #122992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #122976.
/cc @cockroachdb/release
Recently, #113306 attempted to fix an issue in TestMVCCStatsRandomized where a transactional request was silently failing because its timestamp did not match the transaction's read timestamp. That patch handled many of the types of requests in TestMVCCStatsRandomized but not all (e.g. transactional GC requests).
This patch addresses the issue by refactoring the timestamp manipulation to a single place in the test.
Fixes: #119409
Release note: None
Release justification: Test fix