optbuilder: relax a check for SQL routines calling SPs with OUT params

[yuzefovich]

This commit relaxes the check that we have for prohibiting SQL routines to call SPs with OUT parameters. In particular, it's ok for a SQL routine to call a PLpgSQL routine that calls an SP with OUT parameters.

Fixes: #122268.

Release note: None

[cockroach-teamcity]

This change is 

[DrewKimball]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

---

pkg/sql/logictest/testdata/logic_test/procedure line 436 at r1 (raw file):

skipif config local-mixed-23.2
statement error pgcode 0A000 calling procedures with output arguments is not supported in SQL functions
CREATE PROCEDURE p_outer(OUT param INTEGER) AS $$ CALL p_inner(NULL); $$ LANGUAGE SQL;

Could you add a test with an INOUT parameter as well?

---

pkg/sql/logictest/testdata/logic_test/procedure line 447 at r1 (raw file):

    RAISE NOTICE 'a: %', a;
  END
$$ LANGUAGE PLpgSQL;

Did we make it so that PL/pgSQL can be used in non-ccl tests?

[yuzefovich]

TFTR!

bors r+

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @DrewKimball)

---

pkg/sql/logictest/testdata/logic_test/procedure line 436 at r1 (raw file):

Previously, DrewKimball (Drew Kimball) wrote…

Could you add a test with an INOUT parameter as well?

Done.

---

pkg/sql/logictest/testdata/logic_test/procedure line 447 at r1 (raw file):

Previously, DrewKimball (Drew Kimball) wrote…

Did we make it so that PL/pgSQL can be used in non-ccl tests?

Good catch, I didn't realize this was non-ccl file (I locally ran only ccl version and it passed :) ).

[craig]

Build failed:

• unit_tests

[yuzefovich]

One skip for local-mixed-23.2 config was missing.

bors r+

[craig]

Build succeeded:

• windows_build
• examples_orms
• acceptance
• check_generated_code
• macos_amd64_build
• local_roachtest_fips
• lint
• linux_arm64_build
• linux_amd64_fips_build
• linux_amd64_build
• docker_image_amd64
• unit_tests
• local_roachtest
• macos_arm64_build

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 1cc9910 to blathers/backport-release-24.1-122936: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}