Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.1: sql/delegate: don't include external connections in SHOW SYSTEM GRANTS #122857

Merged
merged 1 commit into from
Apr 24, 2024
Merged

release-24.1: sql/delegate: don't include external connections in SHOW SYSTEM GRANTS #122857

merged 1 commit into from
Apr 24, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 22, 2024 •
edited by rafiss
Loading

Backport 1/1 commits from #122720 on behalf of @rafiss.

/cc @cockroachdb/release

Epic: None
Release note (bug fix): Privileges granted for external connections were incorrectly showing up in SHOW SYSTEM GRANTS, but were not useful since there is no associated object name. Now they do not appear there. Instead, the SHOW GRANTS ON EXTERNAL CONNECTION syntax should be used.

Release justification: bug fix

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-122720 branch from 72eced6 to 9363969 Compare April 22, 2024 22:07
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 22, 2024
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Apr 22, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 22, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested review from Dedej-Bergin, a team and mgartner April 23, 2024 16:40
Dedej-Bergin
Dedej-Bergin approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@Dedej-Bergin Dedej-Bergin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner)

@rafiss
sql/delegate: don't include external connections in SHOW SYSTEM GRANTS
df7174a 
Release note (bug fix): Privileges granted for external connections were
incorrectly showing up in SHOW SYSTEM GRANTS, but were not useful since
there is no associated object name. Now they do not appear there.
Instead, the SHOW GRANTS ON EXTERNAL CONNECTION should be used.
@rafiss rafiss force-pushed the blathers/backport-release-24.1-122720 branch from 9363969 to df7174a Compare April 24, 2024 14:45
@rafiss rafiss merged commit 0ca3398 into release-24.1 Apr 24, 2024
19 of 20 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.1-122720 branch April 24, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dedej-Bergin Dedej-Bergin Dedej-Bergin approved these changes

@mgartner mgartner mgartner approved these changes

Assignees

@rafiss rafiss

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @mgartner @Dedej-Bergin @rafiss