-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: ui: make custom chart tool work at store level #122705
Merged
abarganier
merged 2 commits into
release-24.1
from
blathers/backport-release-24.1-122151
Apr 26, 2024
Merged
release-24.1: ui: make custom chart tool work at store level #122705
abarganier
merged 2 commits into
release-24.1
from
blathers/backport-release-24.1-122151
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.1-122151
branch
from
April 19, 2024 18:22
d1eb7b1
to
aa436b8
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 19, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Apr 19, 2024
laurenbarker
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a nit on #122703 (comment), but LGTM
dhartunian
approved these changes
Apr 25, 2024
TFTRs! |
Fixes: #121364 This patch fixes a bug in the DB Console custom chart tool, where selecting the "Per Node" checkbox on a metric would not properly display store-level metrics. The previous expected behavior was that the check box would cause the metric to aggregate across stores at the node level (e.g. if the node had 3 stores, it'd SUM the store-level timeseries together and return a single timeseries for the node). Instead, the feature was only showing the 1st store associated with the node. This was due to a bug in the code used to determine if a metric was store-level. A function was used that improperly assumed that the `cr.node.*` or `cr.store.*` prefix had been stripped from the metric name, which was not always the case. This led to us improperly interpret store-level metrics as node-level. The fix is to fix the logic used to determine if a metric is store-level. Additionally, this patch updates the code to no longer aggregate store-level metrics across each node. Instead, we will now show a single timeseries per-store to provide finer-grained observability into store-level metrics within the custom chart tool. Release note (bug fix): A bug has been fixed in the DB Console's custom chart tool, where store-level metrics were not being displayed properly. Previously, if a store-level metric was selected to be displayed at the store-level on a multi-store node, only data for the 1st store ID associated with that node would be displayed. This patch ensures that data is displayed for all stores present on a node. Additionally, it updates the behavior to show a single timeseries for each store, as opposed to aggregating (e.g. SUM) all stores across the node. This allows finer-grained observability into store-level metrics when using the custom chart tool in DB Console.
#122151 fixed the custom chart tool to properly display store-level metrics. However, it did not include any tests. Despite metric charts being difficult to unit test, we can still test the logic used to determine which metric sources should be included in the timeseries query. This commit adds tests for this logic. Release note: none
abarganier
force-pushed
the
blathers/backport-release-24.1-122151
branch
from
April 26, 2024 17:12
9c4b015
to
8746ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #122151 on behalf of @abarganier.
/cc @cockroachdb/release
Fixes: #121364
This patch fixes a bug in the DB Console custom chart tool, where
selecting the "Per Node" checkbox on a metric would not properly display
store-level metrics. The previous expected behavior was that the check
box would cause the metric to aggregate across stores at the node level
(e.g. if the node had 3 stores, it'd SUM the store-level timeseries
together and return a single timeseries for the node). Instead, the
feature was only showing the 1st store associated with the node.
This was due to a bug in the code used to determine if a metric was
store-level. A function was used that improperly assumed that the
cr.node.*
orcr.store.*
prefix had been stripped from the metricname, which was not always the case. This led to us improperly
interpret store-level metrics as node-level.
The fix is to fix the logic used to determine if a metric is
store-level.
Additionally, this patch updates the code to no longer aggregate
store-level metrics across each node. Instead, we will now show a single
timeseries per-store to provide finer-grained observability into
store-level metrics within the custom chart tool.
Release note (bug fix): A bug has been fixed in the DB Console's custom
chart tool, where store-level metrics were not being displayed properly.
Previously, if a store-level metric was selected to be displayed at the
store-level on a multi-store node, only data for the 1st store ID
associated with that node would be displayed.
This patch ensures that data is displayed for all stores present on a
node. Additionally, it updates the behavior to show a single timeseries
for each store, as opposed to aggregating (e.g. SUM) all stores across
the node. This allows finer-grained observability into store-level
metrics when using the custom chart tool in DB Console.
Release justification: fix for a production-level bug in the DB console.