-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: ui: add static images to asset build step #122704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-121380
branch
from
April 19, 2024 18:22
867ee12
to
e418e73
Compare
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 19, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
requested review from
abarganier,
dhartunian,
laurenbarker,
rickystewart and
a team
April 19, 2024 18:22
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Apr 19, 2024
laurenbarker
approved these changes
Apr 19, 2024
xinhaoz
approved these changes
May 9, 2024
During the `genassets` build + embed step, we were taking just the output of the `db-console-ccl` or `db-console-oss` step which is just a build.js file. This commit adds references to the image assets we want bundled as well. This includes favicon.ico and everything in `./ assets` relative to the db-console build directory. We disable content hashing in webpack in order to keep the filenames static, which bazel requires. The impact should be minimal as we rarely change these images so if they're cached forever, it's fine. This change restores the favicon to the CRDB build and the nice image that shows up in the background of the email signup bar. The size of the final zipped bundle only differs by around 1MB and is already 10MB in size. Fixes: #117876 Epic: None Release note (ui change): the favicon now renders properly for DB Console along with other image files.
dhartunian
force-pushed
the
blathers/backport-release-23.2-121380
branch
from
May 30, 2024 18:53
e418e73
to
5cb2446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #121380 on behalf of @dhartunian.
/cc @cockroachdb/release
During the
genassets
build + embed step, we were taking just the output of thedb-console-ccl
ordb-console-oss
step which is just a build.js file. This commit adds references to the image assets we want bundled as well. This includes favicon.ico and everything in./ assets
relative to the db-console build directory.We disable content hashing in webpack in order to keep the filenames static, which bazel requires. The impact should be minimal as we rarely change these images so if they're cached forever, it's fine.
This change restores the favicon to the CRDB build and the nice image that shows up in the background of the email signup bar.
The size of the final zipped bundle only differs by around 1MB and is already 10MB in size.
Fixes: #117876
Epic: None
Release note (ui change): the favicon now renders properly for DB Console along with other image files.
Release justification: low-risk high impact change to ui