catalog: add descriptor repair to remove missing roles

[fqazi]

Previously, we had a bug that could lead to descriptors having privileages to roles that no longer exist. This could lead to certain commands like SHOW GRANTS breaking. To address this, this patch will add descirptor repair logic to automatically clean up oprhaned privileges.

Fixes: #122552

Release note (bug fix): Add automated clean up / validation for dropped roles inside descriptors.

[blathers-crl]

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[rafiss]

nice, this should be really useful! just had a comment

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @fqazi)

---

pkg/sql/sem/builtins/builtins.go line 5454 at r1 (raw file):

					for _, roleDatum := range (*roles).Array {
						role := tree.MustBeDString(roleDatum)
						roleMap[username.MakeSQLUsernameFromPreNormalizedString(string(role))] = struct{}{}

this can come from user input, so we must use MakeSQLUsernameFromUserInput instead.

[fqazi]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)

---

pkg/sql/sem/builtins/builtins.go line 5454 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

this can come from user input, so we must use MakeSQLUsernameFromUserInput instead.

Done.

[rafiss]

great work! could we backport to 24.1?

Reviewed 23 of 24 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @fqazi)

[fqazi]

@rafiss TFTR!

bors r+

[craig]

Build failed (retrying...):

• check_generated_code

[craig]

Build succeeded:

• check_generated_code
• macos_arm64_build
• docker_image_amd64
• windows_build
• local_roachtest
• lint
• linux_amd64_build
• examples_orms
• linux_arm64_build
• acceptance
• macos_amd64_build
• local_roachtest_fips
• Bazel Essential CI (Cockroach)
• linux_amd64_fips_build

[fqazi]

blathers backport 23.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 91b2074 to blathers/backport-release-23.2-122557: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}