release-24.1: kv: auto-step read sequence on savepoint rollback #121785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #121778 on behalf of @nvanbenschoten.
/cc @cockroachdb/release
Fixes #121752.
Fixes #121748.
This commit fixes the
txnSeqNumAllocator
to conditionally (based on the stepping mode) auto-step the transaction's read sequence number to the write sequence number on savepoint rollbacks.The commit also adds in an assertion into the
txnSeqNumAllocator
that the current read sequence is never part of a batch's ignored sequence number list. This helps us detect the cases that were leading to assertion errors in #121752 much faster.Release note: None
Release justification: avoids assertion failures.