kvclient: remove unused error from TransportFactory #121571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the transport factory could return an error when attempting to retrieve a transport. The error was never used in non-test code, and the only use in test code could be better handled by an assertion directly where the factory created the transport. This change reduces some unnecessary error handling. Epic: none Release note: None
|
This change is |
arulajmani
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andrewbaptist)
|
TFTR! bors r=arulajmani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the transport factory could return an error when attempting to retrieve a transport. The error was never used in non-test code, and the only use in test code could be better handled by an assertion directly where the factory created the transport. This change reduces some unnecessary error handling.
Epic: none
Release note: None