util/json,builtins: miscellaneous improvements around json objects #121390
Conversation
Release note: None
We incorrectly used `jsonString.String` method to populate the list of keys whereas we should've used `string(jsonString)`. This is now fixed. Note that it's not a big deal since this method is only used in a test-only assertion. Release note: None
This method is only called on `jsonObject` in one spot, so we can inline it and remove unused implementations. Release note: None
|
This change is |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
yuzefovich
added
backport-23.2.x
|
TFTR! bors r+ |
yuzefovich
removed
the
backport-23.2.x
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-24.1-121390 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/121510/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 24.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes: #121326.
Release note: None