-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: roachtest: assert limit capacity throughput 90% of baseline #121308
Conversation
This commit enables a throughput assertion on the `limit_capacity` roachtests. The assertion requires that throughput after limiting some nodes capacity is at least 90% of the pre-limit throughput after 2 minutes. Part of: #118866 Release note: None
9b344b1
to
d2e8cf7
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
I'm not sure we should backport this yet. Can we wait until it has been running at least 2 weeks on master without failure before we backport. If it doesn't fail then it is safe to backport, but while this change is good, it has the risk of adding a flake to an otherwise non-flaky test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder: it has been 3 weeks please merge or close your backport! |
Backport 1/1 commits from #119652 on behalf of @kvoli.
/cc @cockroachdb/release
This commit enables a throughput assertion on the
limit_capacity
roachtests. The assertion requires that throughput after limiting some
nodes capacity is at least 90% of the pre-limit throughput after 2
minutes.
Part of: #118866
Release note: None
Release justification: Test only.