Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rangefeed: add batch version of onValues #121207

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

dt
Copy link
Member

@dt dt commented Mar 27, 2024

Release note: none.
Epic: none.

@dt dt requested review from msbutler and a team March 27, 2024 13:50
@dt dt requested a review from a team as a code owner March 27, 2024 13:50
Copy link

blathers-crl bot commented Mar 27, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt force-pushed the pcr-batch branch 2 times, most recently from 440597d to 221dbad Compare March 28, 2024 00:13
@dt
Copy link
Member Author

dt commented Mar 28, 2024

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 28, 2024

Merge conflict.

@msbutler
Copy link
Collaborator

when you rebase this, could you follow up on this?
#120888 (comment)

Release note: none.
Epic: none.
@dt
Copy link
Member Author

dt commented Apr 1, 2024

follow up on this?

done.

@dt
Copy link
Member Author

dt commented Apr 1, 2024

TFTR!

bors r+

@craig craig bot merged commit c43f54c into cockroachdb:master Apr 1, 2024
22 checks passed
@msbutler
Copy link
Collaborator

msbutler commented Apr 1, 2024

backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants