roachprod: add faster restarts, prettier multi-node sql printing #120941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During initial start we are careful to start nodes serially, in order, to ensure the i'th VM's process acquires the i'th node ID. However this makes startup much slower. We also initialize cluster settings. When *restarting* the nodes of an existing cluster however, these steps are not required: the node ID assignments are already persisted in the stores, as are any previously set cluter settings. Thus we can elect to start all the processes in parallel and skip init. Release note: none. Epic: none.
this ensures they don't get put after a -- Release note: none. Epic: none.
|
This change is |
A common debugging flow is to ask raochprod to run some query on all nodes, eg. roachprod sql mycluster -- -e 'select version()'; When the invoked statement returns multiple lines it makes sense to a header above each result set, then the result set as it was returned. However if the result set is a single line per node, printing just that line, rather than a roachprod header and the result set's own header, can make the aggregate result set much easier to read. Release note: none. Epic: none.
herkolategan
approved these changes
Mar 26, 2024
|
TFTR! bors r+ |
|
Already running a review |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple minor quality-of-life improvements motivated by working on long-lived, multi-node DRT clusters.