workload/schemachange: correct error code for referencing dropping enum

[annrpom]

This patch changes the error code expected for referencing an enum that's in the process of being dropped to the proper one.

Epic: none

Release note: None

[cockroach-teamcity]

This change is 

[annrpom]

whoops - we let this one fly under the radar for a bit

i also found a new trick i could try out here (as opposed to reading code (also - thank you, faizan for the cluster setting pointer)):

CREATE TYPE mood AS ENUM ('sad', 'ok', 'happy');
SET CLUSTER SETTING jobs.debug.pausepoints = 'schemachanger.before.exec';
DROP TYPE IF EXISTS mood;
-- other session

in the other session:

root@localhost:26257/defaultdb> CREATE FUNCTION ah (IN p1 mood) RETURNS VOID LANGUAGE SQL AS $$ SELECT NULL $$;       
ERROR: type "mood" does not exist
SQLSTATE: 42704

[rafiss]

ah interesting. have you tested with ./dev test pkg/ccl/testccl/workload/schemachange/ --stress --count=100 --ignore-cache -f=TestWorkload and altering the weights? just asking because there are at least two places where we do use UndefinedTable for types:

cockroach/pkg/sql/resolver.go

Lines 965 to 966 in 007005f

	return nil, sqlerrors.NewUndefinedRelationError(
	tree.NewUnqualifiedTableName(tree.Name(fmt.Sprintf("[%d]", id))))

cockroach/pkg/sql/catalog/descs/getters.go

Line 334 in f250900

return nil, sqlerrors.NewUndefinedRelationError(&tn)

So since the workload hasn't failed so far with this looking for the wrong error code, i wonder if it's actually fine?

[annrpom]

oh interesting! i just tested with ./dev test pkg/ccl/testccl/workload/schemachange/ --stress --ignore-cache -f=TestWorkload & fwiw, i have stressed this workload a bunch this way and this is the first time i have encountered this error

i got:

 "clientTimestamp": "23:46:55.734682",
 "ops": [
  "BEGIN",
  {
   "sql": "ALTER TYPE schema_w1_6.enum_w0_8 DROP VALUE 'd'"
  },
  {
   "sql": "CREATE SCHEMA IF NOT EXISTS schema_w1_6 AUTHORIZATION root"
  },
  {
   "sql": "DROP FUNCTION IF EXISTS \"NoSuchFunction\""
  },
  {
   "sql": "ALTER FUNCTION public.udf_w0_7() RENAME TO udf_w1_15"
  },
  {
   "sql": "CREATE FUNCTION udf_w1_16(IN p1 schema_w1_6.enum_w0_8)\n\tRETURNS VOID\n\tLANGUAGE SQL\n\tAS $$ SELECT NULL $$",
   "expectedExecErr": "42P01"
  }
 ],
 "expectedExecErrors": "42P01",
 "expectedCommitErrors": "",
 "message": "***FAIL; Failed to receive an execution error when errors were expected",

maybe my triage of this was wrong - let me see

[rafiss]

it might be best to go with your change here, and also adjust the places i linked to to use UndefinedObject. as long as the tests pass!

[rafiss]

lgtm!

[annrpom]

TFTR! ('-')7

bors r=rafiss

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

This PR was included in a batch that was canceled, it will be automatically retried

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)
• check_generated_code
• docker_image_amd64
• examples_orms
• linux_amd64_build
• linux_amd64_fips_build
• linux_arm64_build
• macos_amd64_build
• macos_arm64_build
• windows_build