sql/pg_catalog: fix attname for dropped columns #120861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, the attname columns for dropped columns was padded used a %8d string format. This led to incorrect behavior as it meant a total of 8 '.' characters inclusive of the column ordinal as compared to the PG code base which always pads with 8 '.'. This affected migration tooling since it attempts to verify column names using the returned attname and led to mismatching column reports. This commit fixes the issue by explicitly setting the padding to 8 '.' to match the PG implementation. Fixes: cockroachdb#120855 Release note (bug fix): attname for dropped columns is now properly padded with 8 '.' to match PG.
Jeremyyang920
force-pushed
the
jyang/fix_pg_attr_padding
branch
from
473ebdb to
a8aec2b
Compare
fqazi
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Nice, find!
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Jeremyyang920)
|
@rafiss I haven't tagged any backports since not sure how important this would be and can let you make the call on that. |
|
I don't see a need to backport, unless you see it blocking some tool that needs this. I'll merge as-is. thanks for the fix! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the attname columns for dropped columns was padded used a %8d string format. This led to incorrect behavior as it meant a total of 8 '.' characters inclusive of the column ordinal as compared to the PG code base which always pads with 8 '.'. This affected migration tooling since it attempts to verify column names using the returned attname and led to mismatching column reports.
This commit fixes the issue by explicitly setting the padding to 8 '.' to match the PG implementation.
Fixes: #120855
Release note (bug fix): attname for dropped columns is now properly padded with 8 '.' to match PG.