logictest: move large upsert tests to non-metamorphic file #120417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen a few suspicious failures around a couple of test cases in the `upsert` file that use large number of rows, so this commit moves them into the non-metamorphic file in hopes of preventing flakes. Additionally, I'm guessing these test cases were the reason for recently added skip under race, so that is removed too. Epic: None Release note: None
|
This change is |
|
Friendly ping @cockroachdb/sql-queries-prs |
rytaft
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Do you think this will fix #120474?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
|
That issue seems like a dup of #119907 (which this PR is not closing yet - it seems plausible that recent DistSender circuit breaker changes are to blame). TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a few suspicious failures around a couple of test cases in the
upsertfile that use large number of rows, so this commit moves them into the non-metamorphic file in hopes of preventing flakes.Additionally, I'm guessing these test cases were the reason for recently added skip under race, so that is removed too.
Informs: #119907.
Epic: None
Release note: None