-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: roachprod: RAID0 only network disks if both local and network are present #120396
release-23.2: roachprod: RAID0 only network disks if both local and network are present #120396
Conversation
…sent Today, if a machine has both local and network disks, both the disks are selected for RAID'ing. But, RAID'ing different types of disks causes performance differences. To address this, local disks are ignored for RAID'ing only if network disks are present. Fixes: #98783 Epic: none
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @BabuSrithar, @DarrylWong, @herkolategan, @renatolabs, and @srosenberg)
Thanks for backporting this! |
Backport 1/1 commits from #119906 on behalf of @nameisbhaskar.
/cc @cockroachdb/release
Today, if a machine has both local and network disks, both the disks are selected for RAID'ing.
But, RAID'ing different types of disks causes performance differences.
To address this, local disks are ignored for RAID'ing only if network disks are present.
Fixes: #98783
Epic: none
Release justification: test-only change
Release justification: