Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: backuppcl: pass finishesSpec field to resume span #120261

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Mar 12, 2024

Backport 1/2 commits from #120204.

/cc @cockroachdb/release


PR #114268 broke the plumbing for the CompletedSpans metric which allows the backup coordinator to update the FractionCompleted metric. This patch fixes this bug by passing the finishesSpec field to the resume span.

Informs #120161

Release note: none

Release justification: low risk bug fix

PR cockroachdb#114268 broke the plumbing for the CompletedSpans metric which allows the
backup coordinator to update the FractionCompleted metric. This patch fixes
this bug by passing the finishesSpec field to the resume span.

Informs cockroachdb#120161

Release note: none
@msbutler msbutler self-assigned this Mar 12, 2024
@msbutler msbutler requested review from a team as code owners March 12, 2024 02:40
@msbutler msbutler requested review from herkolategan, renatolabs and dt and removed request for a team March 12, 2024 02:40
Copy link

blathers-crl bot commented Mar 12, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 12, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler requested a review from rharding6373 March 12, 2024 15:17
@msbutler msbutler requested a review from stevendanna March 12, 2024 19:08
@msbutler msbutler merged commit 0c3f5d4 into cockroachdb:release-23.2 Mar 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches T-disaster-recovery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants