Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachprod(azure): use machine type to determine hypervisor generation #120248

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 11, 2024

Backport 1/1 commits from #120172 on behalf of @srosenberg.

/cc @cockroachdb/release


In [1], we switched to azure v5 machine series. Some of these newer machine types do not support hypervisor generation 1. By hardcoding generation 2, we effectively broke backward compatibility with older machine types.

As of this change, the hypervisor generation is dynamically selected based on the machine type (see imageSKU).

[1] #117852

Epic: none

Release note: None


Release justification: test-only change

In [1], we switched to azure `v5` machine series. Some of these
newer machine types do not support hypervisor generation 1. By
hardcoding generation 2, we effectively broke backward compatibility
with older machine types.

As of this change, the hypervisor generation is dynamically
selected based on the machine type (see `imageSKU`).

[1] #117852

Epic: none

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 11, 2024 21:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-120172 branch from 10f8aba to 7b3b5a9 Compare March 11, 2024 21:02
@blathers-crl blathers-crl bot requested review from srosenberg and renatolabs and removed request for a team March 11, 2024 21:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 11, 2024
Copy link
Author

blathers-crl bot commented Mar 11, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 11, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg srosenberg requested a review from herkolategan March 12, 2024 11:10
@herkolategan
Copy link
Collaborator

herkolategan commented Mar 12, 2024

CI failure looks like a network blip:

[mixed-version-test/1_start-cluster-at-version-v22.2.10] 22:26:39 runner.go:372: ---------- STARTING (1): start cluster at version "v22.2.10" ----------
[mixed-version-test/1_start-cluster-at-version-v22.2.10] 22:26:39 staging.go:358: Resolved release url for cockroach version v22.2.10: https://storage.googleapis.com/cockroach-release-artifacts-prod/cockroach-v22.2.10.linux-amd64.tgz
curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 104

Hence no cause for holding up.

ps. already triggered a CI re-run.

@srosenberg
Copy link
Member

TFTR!

@srosenberg srosenberg merged commit e0cb7ed into release-23.1 Mar 12, 2024
6 checks passed
@srosenberg srosenberg deleted the blathers/backport-release-23.1-120172 branch March 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants