-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: roachprod(azure): use machine type to determine hypervisor generation #120248
Merged
srosenberg
merged 1 commit into
release-23.1
from
blathers/backport-release-23.1-120172
Mar 12, 2024
Merged
release-23.1: roachprod(azure): use machine type to determine hypervisor generation #120248
srosenberg
merged 1 commit into
release-23.1
from
blathers/backport-release-23.1-120172
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [1], we switched to azure `v5` machine series. Some of these newer machine types do not support hypervisor generation 1. By hardcoding generation 2, we effectively broke backward compatibility with older machine types. As of this change, the hypervisor generation is dynamically selected based on the machine type (see `imageSKU`). [1] #117852 Epic: none Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-120172
branch
from
March 11, 2024 21:02
10f8aba
to
7b3b5a9
Compare
blathers-crl
bot
requested review from
srosenberg and
renatolabs
and removed request for
a team
March 11, 2024 21:02
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Mar 11, 2024
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Mar 11, 2024
CI failure looks like a network blip:
Hence no cause for holding up. ps. already triggered a CI re-run. |
herkolategan
approved these changes
Mar 12, 2024
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #120172 on behalf of @srosenberg.
/cc @cockroachdb/release
In [1], we switched to azure
v5
machine series. Some of these newer machine types do not support hypervisor generation 1. By hardcoding generation 2, we effectively broke backward compatibility with older machine types.As of this change, the hypervisor generation is dynamically selected based on the machine type (see
imageSKU
).[1] #117852
Epic: none
Release note: None
Release justification: test-only change