kvserver: opt-in "fast" external file snapshotting #120030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
Requires cockroachdb/pebble#3384 |
stevendanna
force-pushed
the
external-file-snapshotting
branch
from
a48ecca to
396c31a
Compare
|
@itsbilal I believe we have some work to do on the pebble side re exclusive keys to do. But this should otherwise be more or less ready to review if you want to take a look. |
itsbilal
approved these changes
Mar 15, 2024
Epic: none Release note: None
stevendanna
force-pushed
the
external-file-snapshotting
branch
from
396c31a to
37113e7
Compare
Like SharedSSTs, we may want to send a pebble.ExternalFile's metadata rather than its content during a snapshot. This is opt-in via a cluster setting and is only attempted when the store appears to actually have external files. Epic: none Release note: None
stevendanna
force-pushed
the
external-file-snapshotting
branch
from
37113e7 to
85386fd
Compare
|
bors r=itsbilal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like SharedSSTs, we may want to send a pebble.ExternalFile's metadata
rather than its content during a snapshot.
This is opt-in via a cluster setting and is only attempted when the
store appears to actually have external files.
Epic: none
Release note: None