go.mod: bump Pebble to 1f7e8ee45c85 #120025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * [`1f7e8ee4`](cockroachdb/pebble@1f7e8ee4) iterator: require prefix filtering in merging iterator * [`c7795250`](cockroachdb/pebble@c7795250) db: verify virtualBackings in invariants mode * [`b50ef877`](cockroachdb/pebble@b50ef877) db: rename fileBackings to virtualBackings * [`1e4eca5f`](cockroachdb/pebble@1e4eca5f) manifest: show created/deleted backings in VersionEdit.String * [`ce293cce`](cockroachdb/pebble@ce293cce) wal: work around false data race in failoverWriter * [`08e0a863`](cockroachdb/pebble@08e0a863) db: move skip-remote logic out of manifest.LevelIterator * [`9591f938`](cockroachdb/pebble@9591f938) allow replication of external files * [`f3e3d4aa`](cockroachdb/pebble@f3e3d4aa) db: during WAL failover, don't write stall due to too many memtables * [`1ff6ed8b`](cockroachdb/pebble@1ff6ed8b) db: account for garbage in backing files when picking a compaction * [`6566b6be`](cockroachdb/pebble@6566b6be) metamorphic: inject random IO latency Release note: none. Epic: none.
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
dt
approved these changes
Mar 6, 2024
|
Test failures look like unrelated flakes. |
|
Maybe let's get cockroachdb/pebble#3384 as well. |
Changes: * [`8df4320c`](cockroachdb/pebble@8df4320c) db: rework backing refcount management * [`33f8f045`](cockroachdb/pebble@33f8f045) scan_internal: don't visit empty external files * [`1e816918`](cockroachdb/pebble@1e816918) vfs/vfstest: add WithOpenFileTracking Release note: none. Epic: none.
Done. Gonna bors this now since one of the big test clusters just hit a manifest corruption bug that was fixed in c7795250 so I want to get this in before I need to rebuild it again. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
1f7e8ee4iterator: require prefix filtering in merging iteratorc7795250db: verify virtualBackings in invariants modeb50ef877db: rename fileBackings to virtualBackings1e4eca5fmanifest: show created/deleted backings in VersionEdit.Stringce293ccewal: work around false data race in failoverWriter08e0a863db: move skip-remote logic out of manifest.LevelIterator9591f938allow replication of external filesf3e3d4aadb: during WAL failover, don't write stall due to too many memtables1ff6ed8bdb: account for garbage in backing files when picking a compaction6566b6bemetamorphic: inject random IO latencyRelease note: none.
Epic: none.