-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: kvserver: refresh range cache on rangefeed barrier failure #119545
Merged
erikgrinaker
merged 1 commit into
cockroachdb:release-22.2
from
erikgrinaker:backport22.2-119512
Feb 22, 2024
Merged
release-22.2: kvserver: refresh range cache on rangefeed barrier failure #119545
erikgrinaker
merged 1 commit into
cockroachdb:release-22.2
from
erikgrinaker:backport22.2-119512
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Feb 22, 2024
rharding6373
approved these changes
Feb 22, 2024
The DistSender does not refresh its range cache for unsplittable requests. This could cause a rangefeed transaction pusher barrier request to persistently fail following a range merge if the range cache thought the barrier spanned multiple ranges. This would only resolve once the range cache was refreshed by some other request, which might never happen. This in turn would cause the rangefeed's resolved timestamp to stall. Epic: none Release note (bug fix): fixed a bug where rangefeed resolved timestamps could get stuck, continually emitting the log message "pushing old intents failed: range barrier failed, range split", typically following a range merge. This bug was introduced in v22.2.18.
erikgrinaker
force-pushed
the
backport22.2-119512
branch
from
February 22, 2024 22:25
685e704
to
412a166
Compare
nvanbenschoten
approved these changes
Feb 22, 2024
blathers backport staging-v22.2.19 |
rmloveland
added a commit
to cockroachdb/docs
that referenced
this pull request
Feb 23, 2024
rmloveland
added a commit
to cockroachdb/docs
that referenced
this pull request
Feb 26, 2024
* Add release notes for v22.2.19 Fixes DOC-9749 * Update with reviewer feedback * Add release note from cockroachdb/cockroach#119545 * Update SHA for v22.2.19 * Update v22.2.19 with correct backport PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #119512.
/cc @cockroachdb/release
Release justification: fixes a recently introduced bug that could stall rangefeed resolved timestamps.
The DistSender does not refresh its range cache for unsplittable requests. This could cause a rangefeed transaction pusher barrier request to persistently fail following a range merge if the range cache thought the barrier spanned multiple ranges. This would only resolve once the range cache was refreshed by some other request, which might never happen. This in turn would cause the rangefeed's resolved timestamp to stall.
Resolves #119536.
Resolves #119333.
Epic: none
Release note (bug fix): fixed a bug where rangefeed resolved timestamps could get stuck, continually emitting the log message "pushing old intents failed: range barrier failed, range split", typically following a range merge. This bug was introduced in v22.2.18.