Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvcoord: evict range cache on unsplittable batches #119510

Conversation

erikgrinaker
Copy link
Contributor

Prototype fix for #119333. Possibly not ideal or backportable, since we can end up evicting range descriptors too often, incurring meta lookup latency.

Maybe we can eagerly refresh the cache here and pay the cost only for the unsplittable requests instead, which are less latency-sensitive (AddSSTable and Barrier).

Epic: none
Release note: None

Copy link

blathers-crl bot commented Feb 22, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker force-pushed the distsender-unsplittable-evict-cache branch from e69be8b to d53805b Compare February 22, 2024 11:47
@erikgrinaker
Copy link
Contributor Author

Kicking off 10 runs of c2c/tpcc/warehouses=1000/duration=60/cutover=30 to verify.

@erikgrinaker
Copy link
Contributor Author

Kicking off 10 runs of c2c/tpcc/warehouses=1000/duration=60/cutover=30 to verify.

10/10 passed.

@erikgrinaker
Copy link
Contributor Author

Closing in favor of #119512.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants