awsdms: don't use secure roachprod cluster #119394
Conversation
With a change to MakeClusterSettings, roachprod clusers were set to be in secure mode by default. We don't need this for our test so we will be going back to the default behavior so we can use sslmode None for the dms endpoint settings. Fixes: cockroachdb#119051 Release note: None
Jeremyyang920
requested review from
DarrylWong and
renatolabs
and removed request for
a team
|
This change is |
|
No need to backport as it seems the change has only affected the 24.1 test run on Feb 10 and 17. |
|
bors r=ZhouXing19 |
|
Ah sorry for not catching this earlier. The weekly tests always slip my mind. I think you'll want to revert these diffs for Actually on a deeper look, it looks like the password is ignored anyway. Probably fine as is, up to you if you want to revert the comment for clarity. |
@DarrylWong Thanks for the followup. Yea the password is ignored either way and the test passed on my local run. |
|
Build succeeded: |
With a change to MakeClusterSettings, roachprod clusers were set to be in secure mode by default. We don't need this for our test so we will be going back to the default behavior so we can use sslmode None for the dms endpoint settings.
Fixes: #119051
Release note: None