-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvcoord: add Transport.Reset()
#119349
kvcoord: add Transport.Reset()
#119349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist and @erikgrinaker)
pkg/kv/kvclient/kvcoord/transport_test.go
line 134 at r1 (raw file):
gt.SkipReplica() require.True(t, gt.IsExhausted()) gt.Reset()
nit: Want to add in a require.False(t, gt.IsExhausted())
after this?
This resets the transport back to the first replica in the list. Epic: none Release note: None
6474c6b
to
72eec2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @andrewbaptist and @nvanbenschoten)
pkg/kv/kvclient/kvcoord/transport_test.go
line 134 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
nit: Want to add in a
require.False(t, gt.IsExhausted())
after this?
Yep, good call, done.
Sigh, Reviewable keeps doing this. I thought unchecking "Sync requested reviewers" was the thing to do, but maybe it actually needs to be checked. |
Build succeeded: |
Extracted from #118943.
This resets the transport back to the first replica in the list.
Epic: none
Release note: None