Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvcoord: add Transport.Reset() #119349

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

erikgrinaker
Copy link
Contributor

Extracted from #118943.


This resets the transport back to the first replica in the list.

Epic: none
Release note: None

@erikgrinaker erikgrinaker self-assigned this Feb 18, 2024
@erikgrinaker erikgrinaker requested a review from a team February 18, 2024 16:22
@erikgrinaker erikgrinaker requested a review from a team as a code owner February 18, 2024 16:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@nvanbenschoten nvanbenschoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist and @erikgrinaker)


pkg/kv/kvclient/kvcoord/transport_test.go line 134 at r1 (raw file):

	gt.SkipReplica()
	require.True(t, gt.IsExhausted())
	gt.Reset()

nit: Want to add in a require.False(t, gt.IsExhausted()) after this?

This resets the transport back to the first replica in the list.

Epic: none
Release note: None
Copy link
Contributor Author

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @andrewbaptist and @nvanbenschoten)


pkg/kv/kvclient/kvcoord/transport_test.go line 134 at r1 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

nit: Want to add in a require.False(t, gt.IsExhausted()) after this?

Yep, good call, done.

@erikgrinaker
Copy link
Contributor Author

erikgrinaker requested a review from nvanbenschoten now

Sigh, Reviewable keeps doing this. I thought unchecking "Sync requested reviewers" was the thing to do, but maybe it actually needs to be checked.

@craig
Copy link
Contributor

craig bot commented Feb 20, 2024

Build succeeded:

@craig craig bot merged commit 44e45c7 into cockroachdb:master Feb 20, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants