roachtest: run follower-reads/mixed-version on insecure mode #119143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
DarrylWong
force-pushed
the
insecure-follower-reads
branch
3 times, most recently
from
c28c155 to
a7d379c
Compare
|
Ran Also ran |
Due to a new field added in 23.1, authentication will fail if the cluster is migrating from 22.2 to 23.1. We disable secure mode for these test to avoid this issue all together. This change also adds a check in RoachtestHTTPClient to only add cookies if the cluster is running in secure mode. This is so we can use the same HTTP Client for both mixed-version and non mixed-version follower-reads tests. Release note: none
DarrylWong
force-pushed
the
insecure-follower-reads
branch
from
a7d379c to
d708f53
Compare
DarrylWong
requested review from
herkolategan and
srosenberg
and removed request for
a team
renatolabs
approved these changes
Feb 14, 2024
|
TFTR! bors r=renatolabs |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a new field added in 23.1, authentication will fail if the cluster is migrating from 22.2 to 23.1. We disable secure mode to avoid this issue all together.
This change also adds a check in RoachtestHTTPClient to only add cookies if the cluster is running in secure mode. This is so we can use the same HTTP Client for both mixed-version and non mixed-version follower-reads tests.
Release note: none
Epic: none
Fixes: #119064