roachprod: add port flags for start commands #119086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `roachprod` did not provide a way to specify ports, when starting cockroach. This change adds the ability to pass a `sql-port` and `admin-ui-port` if the user wishes to start an instance with specific ports. Resolves: cockroachdb#118945 Release Note: None
|
This change is |
|
I'm aware of this https://github.com/cockroachdb/cockroach/blob/master/pkg/cmd/roachprod/main.go#L572 (which will override what the flag is set to currently). But I don't think we should address it in this PR, but rather when #117125 is addressed. |
herkolategan
requested review from
DarrylWong and
renatolabs
and removed request for
a team
DarrylWong
approved these changes
Feb 13, 2024
|
TFTR! bors r=DarrylWong |
|
Build succeeded: |
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
roachproddid not provide a way to specify ports, when starting cockroach. This change adds the ability to pass asql-portandadmin-ui-portif the user wishes to start an instance with specific ports.Resolves: #118945
Release Note: None