tree: correctly format the "unknown" oid for pg compatibility

[DrewKimball]

The REGTYPE, REGPROC, REGCLASS, and REGNAMESPACE types are all
in the oid type family, but unlike OID, display - instead of 0 when
the value is zero. Previously, this was handled by setting the name field
of DOid to -, but the handling was incomplete. This commit removes the
old special cases, and instead adds special handling to the functions that
parse an oid from a string, as well as the DOid.Format() method. This way,
correctly formatting the "unknown" oid doesn't rely on remembering to set
the name field.

In addition, this commit modifies some of the random datum generation
logic to create types other than the canonical T_oid, like T_regrole.

Fixes #118273

Release note: None

[cockroach-teamcity]

This change is 

[michae2]

Nice find!!

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

[mgartner]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @rytaft)

[DrewKimball]

TFTRs!

I ended up having to make some changes to the places where we generate datums for tests, as well.

[mgartner]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @rytaft)

[DrewKimball]

After wrestling with tests for a bit, I've changed the approach. I removed the old (incomplete) handling of "unknown" oids. We now only output the - when either printing text results to the client, or when casting to a string. There are also two locations where we parse an oid from a string; those correctly handle - as well.

[yuzefovich]

Reviewed 1 of 5 files at r2, 12 of 12 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (and 2 stale) (waiting on @DrewKimball, @mgartner, @michae2, and @rytaft)

---

pkg/sql/logictest/testdata/logic_test/pgoidtype line 702 at r3 (raw file):

INSERT INTO t118273 VALUES (0, 0);

skipif config local-mixed-23.1

nit: I think you can mention multiple configs to skip on a single line.

[rafiss]

nice!

Reviewed 1 of 5 files at r2, 12 of 12 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (and 2 stale) (waiting on @DrewKimball, @mgartner, @michae2, and @rytaft)

[DrewKimball]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 3 stale) (waiting on @mgartner, @michae2, @rafiss, @rytaft, and @yuzefovich)

---

pkg/sql/logictest/testdata/logic_test/pgoidtype line 702 at r3 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: I think you can mention multiple configs to skip on a single line.

TIL, thanks.

[yuzefovich]

@DrewKimball should we push it over the finish line? We just got another failure like this over in #122817

[DrewKimball]

Sorry, I lost track of this one. I'll rebase.

[DrewKimball]

TFTRs!

bors r+

[craig]

Build succeeded:

• linux_amd64_fips_build
• linux_amd64_build
• macos_amd64_build
• local_roachtest_fips
• docker_image_amd64
• lint
• unit_tests
• local_roachtest
• check_generated_code
• macos_arm64_build
• linux_arm64_build
• windows_build
• examples_orms
• acceptance

[yuzefovich]

blathers backport release-24.1

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from a4b6234 to blathers/backport-release-24.1-118587: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-24.1 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[yuzefovich]

blathers backport release-23.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from a4b6234 to blathers/backport-release-23.2-118587: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-23.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[mgartner]

blathers backport release-23.1

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from a4b6234 to blathers/backport-release-23.1-118587: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-23.1 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}