Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: batcheval: add BarrierRequest.WithLeaseAppliedIndex #118407

Merged
merged 4 commits into from
Feb 1, 2024
Merged

release-23.2: batcheval: add BarrierRequest.WithLeaseAppliedIndex #118407

merged 4 commits into from
Feb 1, 2024

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Jan 29, 2024 •
edited
Loading

This is part of a #117612 backport.

With the exception of the isAlone flag, this PR does not have any behavioral changes -- it only adds unused (for now) APIs. I'll verify that the isAlone change is compatible with all uses back to 22.2 (for mixed-version clusters), which I'm pretty sure is the case.

Backport:

Please see individual PRs for details.

Release justification: prerequisites for backporting #117612.

/cc @cockroachdb/release

@erikgrinaker
kvpb: mark BarrierRequest as isAlone
47cd435 
Otherwise, `BatchRequest.RequiresConsensus()` may return `false` and not
submit the barrier through Raft. Similarly,
`shouldWaitOnLatchesWithoutAcquiring` will return `false` so it will
contend with later writes.

Barriers are not used in recent releases, so this does not have any
mixed-version concerns.

Epic: none
Release note: None
@erikgrinaker
batcheval: add BarrierRequest.WithLeaseAppliedIndex
9373cfa 
This can be used to detect whether a replica has applied the barrier
command yet.

Epic: none
Release note: None
@erikgrinaker
kvnemsis: add support for Barrier operations
5544e5d 
This only executes random `Barrier` requests, but does not verify that
the barrier guarantees are actually satisfied (i.e. that all past and
concurrent writes are applied before it returns). At least we get some
execution coverage, and verify that it does not have negative
interactions with other operations.

Epic: none
Release note: None
@erikgrinaker
kvserver: add Replica.WaitForLeaseAppliedIndex()
954f001 
This allows a caller to wait for a replica to reach a certain lease
applied index. Similar functionality elsewhere is not migrated yet, out
of caution.

Epic: none
Release note: None
@erikgrinaker erikgrinaker self-assigned this Jan 29, 2024
@erikgrinaker erikgrinaker requested a review from a team as a code owner January 29, 2024 10:55
@erikgrinaker erikgrinaker requested a review from a team January 29, 2024 10:55
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Jan 29, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 29, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker changed the title release-23.2: batcheval: add `BarrierRequest.WithLeaseAppliedIndex release-23.2: batcheval: add BarrierRequest.WithLeaseAppliedIndex Jan 29, 2024
@erikgrinaker erikgrinaker mentioned this pull request Jan 29, 2024
Merged
@erikgrinaker
Copy link
Contributor Author

I'll verify that the isAlone change is compatible with all uses back to 22.2

The last use of Barrier appears to be in 21.2, where it was initially introduced, as part of an upgrade migration. So no mixed-version concerns back to 22.2 inclusive.

@erikgrinaker erikgrinaker merged commit 5c319a1 into cockroachdb:release-23.2 Feb 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rharding6373 rharding6373 rharding6373 approved these changes

@nvanbenschoten nvanbenschoten nvanbenschoten approved these changes

Assignees

@erikgrinaker erikgrinaker

Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikgrinaker @cockroach-teamcity @nvanbenschoten @rharding6373