-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: sqlproxyccl: add proxy protocol listener #117865
release-23.2: sqlproxyccl: add proxy protocol listener #117865
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not familiar with the code being changes, but confirming that the backport is low risk to the main CRDB process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The code changed impacts the sqlproxy, which is only used in serverless deployments.
To support GCP Private Service Connect, we need to have a listener in SQLProxy which expects packets to contain proxy protocol headers. This listener will be used for all traffic inbound from PSC. At the same time, SQLProxy must continue to accept connections through the public Internet which will not contain proxy protocol headers, and for which any proxy protocol headers we receive cannot be trusted. This commit introduces an optional second listener in SQLProxy, controlled by `--proxy-protocol-listen-addr`, which requires proxy protocol even as the primary listener doesn't. Private Service Connect will direct traffic to this second listener. Resolves cockroachdb#117240 Release note: None
1b115d7
to
39368ae
Compare
Backport 1/1 commits from #117241.
/cc @cockroachdb/release
Release justification: high-priority business need for the functionality; the new functionality is only accessed by a startup flag; the new functionality only affects SQLProxy, not CRDB itself.
To support GCP Private Service Connect, we need to have a listener in
SQLProxy which expects packets to contain proxy protocol headers. This
listener will be used for all traffic inbound from PSC. At the same
time, SQLProxy must continue to accept connections through the public
Internet which will not contain proxy protocol headers, and for which
any proxy protocol headers we receive cannot be trusted.
This commit introduces an optional second listener in SQLProxy,
controlled by
--proxy-protocol-listen-addr
, which requiresproxy protocol even as the primary listener doesn't. Private Service
Connect will direct traffic to this second listener.
Resolves #117240
Release note: None