Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: fix assertion output in TestReplicationStatusReportIntegration #117819

Merged

Conversation

nvanbenschoten
Copy link
Member

Informs #117175.

This doesn't fix the failing test, but it resolves the nonsensical failure message and allows us to debug the test.

Release note: None

Informs cockroachdb#117175.

This doesn't fix the failing test, but it resolves the nonsensical
failure message and allows us to debug the test.

Release note: None
@nvanbenschoten nvanbenschoten added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Jan 16, 2024
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner January 16, 2024 16:28
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 16, 2024

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jan 17, 2024

Build succeeded:

@craig craig bot merged commit 07f8311 into cockroachdb:master Jan 17, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants