Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allocatorimpl: check IO overload in should transfer lease #116875

Merged
merged 1 commit into from
Dec 20, 2023
Merged

allocatorimpl: check IO overload in should transfer lease #116875

merged 1 commit into from
Dec 20, 2023

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Dec 20, 2023

Previously, when the lease IO overload enforcement was set to shed and a store satisfied the IO overload criteria, it would not be guaranteed to have its leases enqueued into the replicate queue. Add an IO overload check in should transfer lease to ensure it does.

Epic: none
Release note: None

@kvoli
allocatorimpl: check IO overload in should transfer lease
30da6af 
Previously, when the lease IO overload enforcement was set to shed and
a store satisfied the IO overload criteria, it would not be guaranteed
to have its leases enqueued into the replicate queue. Add an IO overload
check in should transfer lease to ensure it does.

Epic: none
Release note: None
@kvoli kvoli added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. labels Dec 20, 2023
@kvoli kvoli self-assigned this Dec 20, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli marked this pull request as ready for review December 20, 2023 19:32
@kvoli kvoli requested a review from a team as a code owner December 20, 2023 19:32
@kvoli kvoli requested a review from andrewbaptist December 20, 2023 19:32
andrewbaptist
andrewbaptist approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment •
edited by cockroach-dev-inf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks for making this change. This should help handle io oveload much better!

@kvoli
Copy link
Collaborator Author

kvoli commented Dec 20, 2023

TYFTR

bors r=andrewbaptist

@craig
Copy link
Contributor

craig bot commented Dec 20, 2023

Build succeeded:

@craig craig bot merged commit 611607c into cockroachdb:master Dec 20, 2023
9 checks passed
This was referenced Dec 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbaptist andrewbaptist andrewbaptist approved these changes

Assignees

@kvoli kvoli

Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvoli @cockroach-teamcity @andrewbaptist