Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: kv: disable use of {shared,replicated} locks in conjunction with skip locked #116776

Merged

Conversation

arulajmani
Copy link
Collaborator

@arulajmani arulajmani commented Dec 19, 2023

Backport PRs: #116446 #116461

Release justification: throws error on unsupported behavior to avoid confusion.

We currently don't support the use of shared locks and the skip locked
wait policy together. Until this limitation is lifted, we should return
unimplemented errors instead of the wrong result.

Informs cockroachdb#110743

Release note: None
Currently, requests running with the skip locked wait policy only have
a handle into the in-memory lock table during evaluation, which excludes
uncontended replicated locks. As such, any conflicting replicated locks
may result in a `LockConflictError` after evaluation instead of getting
skipped over -- this breaks expectations about the skip locked wait
policy.

The linked issue talks about fixing this behaviour. Until fixed, we
disallow interactions between the skip locked wait policy and replicated
locks by transforming `LockConflictErrors` returned by evaluation of
skip locked requests into unimplemented errors.

Informs cockroachdb#115057

Release note: None
@arulajmani arulajmani requested a review from a team as a code owner December 19, 2023 14:34
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@arulajmani arulajmani changed the title kv: disable use of {shared,replicated} locks in conjunction with skip locked release-23.2: kv: disable use of {shared,replicated} locks in conjunction with skip locked Dec 19, 2023
@arulajmani arulajmani added the backport Label PR's that are backports to older release branches label Dec 19, 2023
@nvanbenschoten nvanbenschoten merged commit 253a0a0 into cockroachdb:release-23.2 Dec 19, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants