roachtest: specify port for post test timeseries collection #116695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After cockroachdb#114097, we need to specify ports for cockroach node connections. This one was missed and timeseries were not being collected in test failures. Release note: none Epic: none
DarrylWong
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
renatolabs
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Lack of any form of end to end testing of roachtet itself makes catching issues like this virtually impossible 😞 .
How did you learn about this bug?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @srosenberg)
|
I noticed it failing on the |
|
TFTR! bors r=renatolabs |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #114097, we need to specify ports for cockroach node connections. This one was missed and timeseries were not being collected in test failures.
Release note: none
Epic: none