kvclient: remove RPCContext from DistSender #116644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andrewbaptist
force-pushed
the
2023-12-17-remove-dist-sender-clock
branch
from
1cc3c60 to
dd4ef8a
Compare
andrewbaptist
requested review from
dhartunian and
yuzefovich
and removed request for
a team
yuzefovich
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist, @arulajmani, @dhartunian, and @nvanbenschoten)
pkg/kv/kvclient/kvcoord/dist_sender.go line 668 at r1 (raw file):
healthFunc: cfg.HealthFunc, latencyFunc: cfg.LatencyFunc, stopper: cfg.Stopper,
nit: maybe move stopper to be after st?
pkg/kv/kvserver/store_test.go line 259 at r1 (raw file):
Clock: cfg.Clock, NodeDescs: mockNodeStore{desc: nodeDesc},
nit: stray new line.
andrewbaptist
force-pushed
the
2023-12-17-remove-dist-sender-clock
branch
from
dd4ef8a to
692d4f8
Compare
|
bors r=yuzefovich TFTR! (and the really quick turnaround) |
RPCContext is unnecessary in DistSender. The only two things that are needed are the LatencyFunc, which is extracted from the RemoteClocks, and the Stopper which should have been passed in directly. This change makes DistSender a tiny bit more easily testable. Epic: none Release note: None
andrewbaptist
force-pushed
the
2023-12-17-remove-dist-sender-clock
branch
from
692d4f8 to
de430df
Compare
|
Canceled. |
|
bors retry Fixed the incorrect spacing from the merge conflict. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPCContext is unnecessary in DistSender. The only two things that are needed are the LatencyFunc, which is extracted from the RemoteClocks, and the Stopper which should have been passed in directly. This change makes DistSender a tiny bit more easily testable.
Epic: none
Release note: None