allocator: safe format allocator log messages

[kvoli]

See individual commit messages.

Note stringer tests are added in earlier PRs in order to assert against regressions.

Resolves: #102948
Release note: None

[cockroach-teamcity]

This change is 

[andrewbaptist]

Thanks for cleaning this all up! Only once question/concern about whether constraints are considered sensitive, otherwise it all looks good.

Reviewed 4 of 4 files at r1, 4 of 4 files at r2, 2 of 2 files at r3, 5 of 5 files at r4, 4 of 4 files at r5, 2 of 2 files at r6, 5 of 5 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @kvoli)

---

pkg/kv/kvserver/allocator/allocatorimpl/allocator.go line 442 at r5 (raw file):

		}
		b.SafeRune('{')
		b.Print(ae.constraints[i])

I'm concerned that constraints may be considered sensitive data. We consider database and table names as sensitive data, but this is a little less clear. Who is the right person to make this call?

---

pkg/kv/kvserver/allocator/allocatorimpl/allocator_scorer_test.go line 1677 at r2 (raw file):

		cl = append(cl, candidate{
			store:           roachpb.StoreDescriptor{StoreID: roachpb.StoreID(i)},
			valid:           i%2 == 0,

nit: No need to change this, but it might have been easier for all these i%2 cases to instead have 12 different candidates, and each of them only change one parameter (e.g. - i%12 == 5). The advantage of that approach would be if there were "cross-wired" mappings it would be very obvious.

[kvoli]

TYFTR -- replied below re: constraints being considered sensitive.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @andrewbaptist)

---

pkg/kv/kvserver/allocator/allocatorimpl/allocator.go line 442 at r5 (raw file):

Previously, andrewbaptist (Andrew Baptist) wrote…

I'm concerned that constraints may be considered sensitive data. We consider database and table names as sensitive data, but this is a little less clear. Who is the right person to make this call?

These will be redacted -- as they do not implement a SafeFormat or SafeValue method which Print here checks for.

cockroach/pkg/roachpb/span_config.go

Line 139 in 6fae6a7

func (c ConstraintsConjunction) String() string {

This behavior hasn't changed, just that the parts around the constraints won't be redacted now.

[kvoli]

Should be good for another review round @andrewbaptist.

[andrewbaptist]

[kvoli]

TYFTR

bors r=andrewbaptist

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)