Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: roachtest: use context timeout to bound descriptor validation check #116067

Merged
merged 1 commit into from
Dec 12, 2023
Merged

release-23.2: roachtest: use context timeout to bound descriptor validation check #116067

merged 1 commit into from
Dec 12, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 11, 2023 •
edited by msbutler
Loading

Backport 1/1 commits from #116001 on behalf of @msbutler.

/cc @cockroachdb/release

Previously, the CheckInvalidDescriptors utility would set the crdb statement_timeout session variable to 1 minute, which would inadvertently cause subsequent long running queries to fail. This patch runs the validation check with a context timeout instead.

Fixes #115852
Fixes #115956
Fixes #115862

Release note: none

Release justification: test only change

@msbutler
roachtest: use context timeout to bound descriptor validation check
2c685f0 
Previously, the CheckInvalidDescriptors utility would set the crdb
`statement_timeout` session variable to 1 minute, which would inadvertently
cause subsequent long running queries to fail. This patch runs the validation
check with a context timeout instead.

Fixes #115852
Fixes #115956
Fixes #115862

Release note: none
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 11, 2023 15:11
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-116001 branch from 43ecf32 to 2c685f0 Compare December 11, 2023 15:11
@blathers-crl blathers-crl bot requested review from srosenberg and DarrylWong and removed request for a team December 11, 2023 15:11
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 11, 2023
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Dec 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 11, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler merged commit e243152 into release-23.2 Dec 12, 2023
5 of 6 checks passed
@msbutler msbutler deleted the blathers/backport-release-23.2-116001 branch December 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herkolategan herkolategan herkolategan approved these changes

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

@DarrylWong DarrylWong Awaiting requested review from DarrylWong DarrylWong is a code owner automatically assigned from cockroachdb/test-eng

@adityamaru adityamaru Awaiting requested review from adityamaru

@annrpom annrpom Awaiting requested review from annrpom

@renatolabs renatolabs Awaiting requested review from renatolabs

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees

@msbutler msbutler

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @herkolategan @msbutler