cloud,backupccl: add object-locked test variants #115616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test variant that runs backup/restore against an
object-locked bucket. We assume that a second AWS bucket exists with
the -locked prefix to run these tests.
This test would have discovered a recently, near-miss:
--- FAIL: TestCloudBackupRestoreS3/object-locked-bucket (2.34s)
--- PASS: TestCloudBackupRestoreS3/regular-bucket (19.41s)
Epic: none
Release note: None
|
This change is |
|
The ignore-whitespace diff is easier to read on this one: https://github.com/cockroachdb/cockroach/pull/115616/files?diff=unified&w=1 |
|
Running this through the nightly cloud tests here: https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_CloudUnitTests/12989162?hideProblemsFromDependencies=false&hideTestsFromDependencies=false |
adityamaru
approved these changes
Dec 5, 2023
|
@stevendanna should we rebase and merge now that the patch has been reverted on master #115713 |
|
bors r=adityamaru |
|
Build succeeded: |
|
blathers backport 23.2 23.1 |
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test variant that runs backup/restore against an object-locked bucket. We assume that a second AWS bucket exists with the -locked prefix to run these tests.
This test would have discovered a recent, near-miss:
Epic: none
Fixes #79771
Release note: None