-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: roachtest: stop using ClusterSpec.Cloud in test code #115389
Merged
RaduBerinde
merged 5 commits into
cockroachdb:release-23.1
from
RaduBerinde:backport23.1-111324
Dec 5, 2023
Merged
release-23.1: roachtest: stop using ClusterSpec.Cloud in test code #115389
RaduBerinde
merged 5 commits into
cockroachdb:release-23.1
from
RaduBerinde:backport23.1-111324
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces boilerplate in the `Option` code by making it a func instead of an interface with an apply func. This way each option can define the function inline instead of having to define a type. Epic: none Release note: None
This commit moves GCE and AWS specific settings to their own inline structs and adds Options for them. Epic: none Release note: None
`ClusterSpec` now provides options for GCE and AWS machine types. Epic: none Release note: None
`ClusterSpec` now provides options for GCE and AWS zones specification. Epic: none Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Dec 1, 2023
This change removes all remaining uses of `ClusterSpec.Cloud` except those internal to roachtest. Code that is part of running a test now uses `Cluster.Cloud()` instead. Informs: cockroachdb#104029 Release note: None
RaduBerinde
force-pushed
the
backport23.1-111324
branch
from
December 1, 2023 03:30
f7355a6
to
31718a3
Compare
renatolabs
approved these changes
Dec 5, 2023
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5/5 commits from #111324.
/cc @cockroachdb/release
Release justification: test-only change, keeping roachtest in sync
In this PR we fix all test registration code which was depending on the flags passed to
roachtest
(indirectly, through TestSpec). In the process, I tried to clean up various things I had to touch.This makes progress in the direction of #104029 and of making the registry and
TestSpec
not depend at all on the flags (the flags should come in later, when we create an actual cluster from the spec).roachtest: spec: simplify Option
This commit reduces boilerplate in the
Option
code by making it afunc instead of an interface with an apply func. This way each option
can define the function inline instead of having to define a type.
Epic: none
Release note: None
roachtest: spec: provide options for GCE/AWS settings
This commit moves GCE and AWS specific settings to their own
inline structs and adds Options for them.
Epic: none
Release note: None
roachtest: clean up instance type specification
ClusterSpec
now provides options for GCE and AWS machine types.Epic: none
Release note: None
roachtest: clean up zones specification
ClusterSpec
now provides options for GCE and AWS zonesspecification.
Epic: none
Release note: None
roachtest: stop using ClusterSpec.Cloud in test code
This change removes all remaining uses of
ClusterSpec.Cloud
exceptthose internal to roachtest. Code that is part of running a test now
uses
Cluster.Cloud()
instead.Informs: #104029
Release note: None