Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add release-eng as reviewer in update_releases #115337

Conversation

renatolabs
Copy link
Contributor

Previously, the PRs created would have no reviewers assigned, making them very easy to be overlooked.

Epic: none

Release note: None

Previously, the PRs created would have no reviewers assigned, making
them very easy to be overlooked.

Epic: none

Release note: None
@renatolabs renatolabs requested a review from a team as a code owner November 30, 2023 16:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@renatolabs
Copy link
Contributor Author

@rail how do I test this?

@rail
Copy link
Member

rail commented Nov 30, 2023

TBH, I don't know. We can just merge it and see :)

@renatolabs
Copy link
Contributor Author

TFTR!

bors r=RaduBerinde

@craig
Copy link
Contributor

craig bot commented Nov 30, 2023

Build succeeded:

@craig craig bot merged commit c441a2c into cockroachdb:master Nov 30, 2023
9 checks passed
@rail
Copy link
Member

rail commented Nov 30, 2023

https://github.com/cockroachdb/cockroach/actions/runs/7051024567/job/19193005090#step:5:113

Error: Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository.

@renatolabs renatolabs deleted the rc/update-releases-file-gh-action-add-reviewers branch November 30, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants