Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batcheval: move remote sst handling to top #115078

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

dt
Copy link
Member

@dt dt commented Nov 26, 2023

We don't want to do any other processing if it is a remote sst.

Release note: none.
Epic: none.

@dt dt requested review from itsbilal and msbutler November 26, 2023 14:04
@dt dt requested a review from a team as a code owner November 26, 2023 14:04
Copy link

blathers-crl bot commented Nov 26, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

We don't want to do any other processing if it is a remote sst.

Release note: none.
Epic: none.
Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Looks like the main thing this is skipping at the moment is the capacity check which we've seen in profiles account for non-trivial time.

@dt
Copy link
Member Author

dt commented Nov 27, 2023

main thing this is skipping at the moment

To be pedantic we're skipping a lot in the remote case, like collision checks, but we were already skipping that before this move. This is move it just moving it the rest of the way, to the very top -- swapping places with the capacity check, which doesn't make sense for remote ssts that don't use capacity.

@dt
Copy link
Member Author

dt commented Nov 27, 2023

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 27, 2023

Build succeeded:

@craig craig bot merged commit 2fe0f11 into cockroachdb:master Nov 27, 2023
8 checks passed
@dt dt deleted the remote-first branch November 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants