Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: kvcoord: disable fatal assertion on transaction commit sanity check #114981

Merged

Conversation

nvanbenschoten
Copy link
Member

Backport 1/1 commits from #107596.

/cc @cockroachdb/release


As #103817 is now a known issue for which a root cause has been identified, the sanity check assertion in place here is disabled, with errors occuring due to the known bug properly linking to the issue ticket. While the transaction coordinator still performs sanity checks to ensure that operations cannot continue on an already-committed transaction, it will no longer log the error with severity FATAL, resulting in node crash, and will instead simply return the error.

Part of: #103817

Release note: None

Release justification: Extraordinary fix to mitigate effects of #103817.

As cockroachdb#103817 is now a known issue for which a root cause has been
identified, the sanity check assertion in place here is disabled, with
errors occuring due to the known bug properly linking to the issue
ticket. While the transaction coordinator still performs sanity checks
to ensure that operations cannot continue on an already-committed
transaction, it will no longer log the error with severity `FATAL`,
resulting in node crash, and will instead simply return the error.

Part of: cockroachdb#103817

Release note: None
@nvanbenschoten nvanbenschoten requested a review from a team as a code owner November 22, 2023 14:56
Copy link

blathers-crl bot commented Nov 22, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 22, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvanbenschoten nvanbenschoten merged commit 4b41c29 into cockroachdb:release-22.2 Nov 28, 2023
2 checks passed
@nvanbenschoten nvanbenschoten deleted the backport22.2-107596 branch November 28, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants