workload/schemachange: update and disable ALTER TYPE DROP VALUE
#114853
Conversation
chrisseto
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
This change is |
chrisseto
changed the title
ALTER TYPE DROP VALUE
chrisseto
force-pushed
the
rsw-drop-value
branch
2 times, most recently
from
6663235 to
f2b181f
Compare
There was a problem hiding this comment.
Thanks for doing this. I left a few comments. I'm okay disabling this for now (but I'm also curious to see if #115612 would fix anything, but it should not block us from merging this first). We can always enable it again later and see once that issue is fixed.
chrisseto
force-pushed
the
rsw-drop-value
branch
4 times, most recently
from
5e5483d to
cd2285c
Compare
Previously, `ALTER TYPE DROP VALUE` was using the procedural generation that is most common in this workload. The desire to add support UDFs required revisiting the implement as referenced enum values cannot be dropped. Unfortunately, there is not a straightforward way to determine if a specific enum is being referenced by other descriptors (namely default expressions for columns and UDFs). After the initial update and a few testing rounds with UDF support, a bug between enums and UDFs was discovered. (See cockroachdb#114844 for details). This commit upgrades the implementation of `ALTER TYPE DROP VALUE` to utilize the `Generate` helper and dodge cases of referenced enum values. Due to the aforementioned bug and another outstanding flake, this commit also disabled `ALTER TYPE DROP VALUE` to prevent further flakes an noise. Epic: CRDB-19168 Informs: cockroachdb#113859, cockroachdb#114844 Release note: None
chrisseto
force-pushed
the
rsw-drop-value
branch
from
cd2285c to
31a2ac9
Compare
|
bors r=Xiang-Gu |
|
Build succeeded: |
|
blathers backport 23.2.0-rc 23.2 |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 31a2ac9 to blathers/backport-release-23.2.0-rc-114853: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2.0-rc failed. See errors above. error creating merge commit from 31a2ac9 to blathers/backport-release-23.2-114853: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Ah, I'm guessing the conflicts are because I alphabetized some of the operations. I'll take a stab at manually backporting! |
31a2ac9 workload/schemachange: update and disable
ALTER TYPE DROP VALUEPreviously,
ALTER TYPE DROP VALUEwas using the procedural generationthat is most common in this workload.
The desire to add support UDFs required revisiting the implement as
referenced enum values cannot be dropped.
Unfortunately, there is not a straightforward way to determine if a
specific enum is being referenced by other descriptors (namely default
expressions for columns and UDFs).
After the initial update and a few testing rounds with UDF support, a
bug between enums and UDFs was discovered. (See #114844 for details).
This commit upgrades the implementation of
ALTER TYPE DROP VALUEtoutilize the
Generatehelper and dodge cases of referenced enum values.Due to the aforementioned bug and another outstanding flake, this commit
also disabled
ALTER TYPE DROP VALUEto prevent further flakes annoise.
Epic: CRDB-19168
Informs: #113859, #114844
Release note: None