Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: ci: separate location for customized builds #114800

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

rail
Copy link
Member

@rail rail commented Nov 21, 2023

Backport 1/1 commits from #95332.

/cc @cockroachdb/release


Previously, we published custom builds to the same bucket and docker repository as the release-* and master builds.

This PR uses separate GCS bucket and GAR repository for builds other than on master and release-* branches. It also removes unused dockerhub login call.

Additionally, customized builds do not push the tag to the release-staging repo and do not consume release verification testing resources.

Fixes: DEVINF-590
Epic: None
Release notes: None

Release justification: build system changes

@rail rail self-assigned this Nov 21, 2023
@rail rail requested review from a team as code owners November 21, 2023 14:56
@rail rail requested review from msbutler and removed request for a team November 21, 2023 14:56
Copy link

blathers-crl bot commented Nov 21, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 21, 2023
Copy link

blathers-crl bot commented Nov 21, 2023

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rail rail requested a review from jlinder November 21, 2023 14:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, we published custom builds to the same bucket and docker
repository as the release-* and master builds.

This PR uses separate GCS bucket and GAR repository for builds other
than on master and release-* branches. It also removes unused dockerhub
login call.

Additionally, customized builds do not push the tag to the
`release-staging` repo and do not consume release verification testing
resources.

Fixes: DEVINF-590
Epic: None
Release note: None
@rail rail force-pushed the backport22.2-95332 branch from a81a49c to d1b95ce Compare November 21, 2023 15:08
@rail rail removed request for a team and msbutler November 21, 2023 15:09
@rail rail merged commit ecba743 into cockroachdb:release-22.2 Nov 21, 2023
5 of 6 checks passed
@rail rail deleted the backport22.2-95332 branch November 21, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants