Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ts: update server queries to account for system tenant id #114662

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 17, 2023

Backport 1/1 commits from #109727 on behalf of @Santamaura.

/cc @cockroachdb/release


Previously, ts queries would consider providing no tenant id and the system tenant id as the same and would return all the aggregated datapoints. This was likely due to the original implementation considering that the system tenant would always want to view all the aggregated data.

This is not the case anymore since the system tenant has the ability to view all the data, system tenant specific data or other tenants data. Therefore this commit adjusts the server query code so that if a system tenant id is provided, it returns data for only the system tenant.

Fixes #108929

Release note (bug fix): adjust ts server queries
to be able to return system tenant only metrics if tenant id is provided, this will fix an issue where some metrics graphs appear to double count.

Some screenshots after the change:
All
Screenshot 2023-08-30 at 10 59 50 AM

System
Screenshot 2023-08-30 at 11 00 25 AM

Tenant
Screenshot 2023-08-30 at 11 00 13 AM


Release justification: low-risk fix.

Previously, ts queries would consider providing no
tenant id and the system tenant id as the same and
would return all the aggregated datapoints. This was
likely due to the original implementation considering
that the system tenant would always want to view all
the aggregated data.

This is not the case anymore since the system tenant has
the ability to view all the data, system tenant specific data
or other tenants data. Therefore this commit adjusts the server
query code so that if a system tenant id is provided, it returns
data for only the system tenant.

Fixes #108929

Release note (bug fix): adjust ts server queries
to be able to return system tenant only metrics if tenant
id is provided, this will fix an issue where some metrics
graphs appear to double count.
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 17, 2023 20:07
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 17, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-109727 branch 2 times, most recently from 518f5e7 to ee0d0fe Compare November 17, 2023 20:07
Copy link
Author

blathers-crl bot commented Nov 17, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 17, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich requested review from dhartunian and a team November 17, 2023 20:08
@yuzefovich yuzefovich closed this Nov 17, 2023
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-109727 branch November 17, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants