Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: fix release qualification script #114490

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

rail
Copy link
Member

@rail rail commented Nov 15, 2023

Previously, the script tried to copy files to the bin directory, but there was no guaranty that the directory existed.

This PR fixes the assumption by creating the bin directory.

Epic: none
Release note: None

Previously, the script tried to copy files to the `bin` directory, but
there was no guaranty that the directory existed.

This PR fixes the assumption by creating the `bin` directory.

Epic: none
Release note: None
@rail rail added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-release T-release Release Engineering & Automation Team backport-23.2.x Flags PRs that need to be backported to 23.2. labels Nov 15, 2023
@rail rail requested review from celiala and rickystewart November 15, 2023 14:00
@rail rail self-assigned this Nov 15, 2023
@rail rail requested a review from a team as a code owner November 15, 2023 14:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rail
Copy link
Member Author

rail commented Nov 15, 2023

bors r=celiala

@craig
Copy link
Contributor

craig bot commented Nov 15, 2023

Build succeeded:

@craig craig bot merged commit 2ebdcfb into cockroachdb:master Nov 15, 2023
3 checks passed
@rail rail deleted the release-qualification-mkdir branch November 15, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release backport-23.2.x Flags PRs that need to be backported to 23.2. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-release Release Engineering & Automation Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants