Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: add online restore roachtest #114326

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

msbutler
Copy link
Collaborator

This patch adds the following roachtest:

restore/online/tpce/400GB/aws/inc-count=1/nodes=4/cpus=8

which restores the TPCE database from a full backup without revision history
using online restore and restarts the tpce workload during the download phase.

Epic: none

Release note: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler
Copy link
Collaborator Author

currently fails in linking phase with:

pq: importing 1052 ranges: failed to verify keys for AddSSTable: end key must be specified

@msbutler msbutler force-pushed the butler-online-restore-roachtest branch 3 times, most recently from 1b7f059 to 09416b8 Compare November 13, 2023 18:17
@msbutler msbutler marked this pull request as ready for review November 13, 2023 18:18
@msbutler msbutler requested a review from a team as a code owner November 13, 2023 18:18
@msbutler msbutler requested a review from a team November 13, 2023 18:18
@msbutler msbutler requested review from a team as code owners November 13, 2023 18:18
@msbutler msbutler requested review from DarrylWong, renatolabs, adityamaru, dt and stevendanna and removed request for a team, DarrylWong and renatolabs November 13, 2023 18:18
@msbutler
Copy link
Collaborator Author

msbutler commented Nov 13, 2023

Only the last 3 commits matter. The rest have already bors'd.

This patch adds the following roachtest:
```
restore/online/tpce/400GB/aws/inc-count=1/nodes=4/cpus=8
```

which restores the TPCE database from a full backup without revision history
using online restore and restarts the tpce workload during the download phase.

Epic: none

Release note: none
@msbutler msbutler force-pushed the butler-online-restore-roachtest branch from 09416b8 to 0a7d912 Compare November 14, 2023 04:40
@msbutler
Copy link
Collaborator Author

TFTR!!

bors r=dt

@craig
Copy link
Contributor

craig bot commented Nov 14, 2023

Build succeeded:

@craig craig bot merged commit 7ba9725 into cockroachdb:master Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants