logictest: add test for mixed-version configs #114309
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @celiala and @RaduBerinde)
pkg/sql/logictest/logictestbase/logictestbase_test.go line 19 at r1 (raw file):
) func TestLogicTestConfigs(t *testing.T) {
Do we maybe want to name this test something like TestLogicTestConfigsHasMixedVersionConfigs? Or alternatively put this into a subtest with t.Run("verify there is a mixed-version config for each supported release", ...)?
pkg/sql/logictest/logictestbase/logictestbase_test.go line 24 at r1 (raw file):
found := false for _, c := range LogicTestConfigs { if c.BootstrapVersion == v {
It might be useful to also check that c.DisableUpgrade == true.
This commit adds a test that verifies that for each supported previous release we have a logictest config that bootstraps the cluster at that version. Informs: cockroachdb#112629 Release note: None
RaduBerinde
force-pushed
the
logictest-check
branch
from
e070cea to
123a2dc
Compare
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/logictest/logictestbase/logictestbase_test.go line 19 at r1 (raw file):
Previously, andyyang890 (Andy Yang) wrote…
Do we maybe want to name this test something like
TestLogicTestConfigsHasMixedVersionConfigs? Or alternatively put this into a subtest witht.Run("verify there is a mixed-version config for each supported release", ...)?
Good point, renamed to TestLogicTestMixedVersionConfigs
There was a problem hiding this comment.
Nice!
Reviewable status:
|
TFTRs! bors r+ |
|
Build succeeded: |
This commit adds a test that verifies that for each supported previous release we have a logictest config that bootstraps the cluster at that version.
Informs: #112629
Release note: None